diff options
author | Somnath Kotur <somnath.kotur@emulex.com> | 2010-10-25 01:11:10 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-10-25 19:14:10 (GMT) |
commit | 63a76944b674bb758232e4213da0da95ae055012 (patch) | |
tree | 70b0389ed576a06cb193a47d15daa7b66b3bf048 | |
parent | 18edc84cf15cbe114dcdf7e8612ee52586d0aad7 (diff) | |
download | linux-fsl-qoriq-63a76944b674bb758232e4213da0da95ae055012.tar.xz |
be2net: Call netif_carier_off() after register_netdev()
Calling netif_carrier_off before register_netdev was causing the network interface
to miss a linkwatch pending event leading to an inconsistent state if the link
is not up when interface is initialized.This is now invoked after register_netdev.
Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/benet/be_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index 1248626..8767355 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c @@ -2556,7 +2556,6 @@ static void be_netdev_init(struct net_device *netdev) netif_napi_add(netdev, &adapter->tx_eq.napi, be_poll_tx_mcc, BE_NAPI_WEIGHT); - netif_carrier_off(netdev); netif_stop_queue(netdev); } @@ -2865,6 +2864,7 @@ static int __devinit be_probe(struct pci_dev *pdev, status = register_netdev(netdev); if (status != 0) goto unsetup; + netif_carrier_off(netdev); dev_info(&pdev->dev, "%s port %d\n", nic_name(pdev), adapter->port_num); return 0; |