diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-10-08 13:49:04 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-10-08 14:29:57 (GMT) |
| commit | 370adc7cb052a29531b8177d3be770ae9e631bd2 (patch) | |
| tree | 0fb94139e12808c74d204d02b25c51b11dd03777 /drivers/staging/bcm/CmHost.c | |
| parent | 02339374cf3a28c30b5a137ab181eed358589dea (diff) | |
| download | linux-fsl-qoriq-370adc7cb052a29531b8177d3be770ae9e631bd2.tar.xz | |
Staging: bcm: silence off by one warning
"status" is used as an index into the Adapter->PackInfo[] array, which
has NO_OF_QUEUES elements.
This code actually works OK. The SearchSfid() function always returns
a valid index or it returns NO_OF_QUEUES + 1. But it looks sloppy and
it makes the static checkers complain.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/bcm/CmHost.c')
| -rw-r--r-- | drivers/staging/bcm/CmHost.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index b411392..6f388a3 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm/CmHost.c @@ -2367,8 +2367,7 @@ int get_dsx_sf_data_to_application(PMINI_ADAPTER Adapter, UINT uiSFId, void __us struct _packet_info *psSfInfo=NULL; BCM_DEBUG_PRINT( Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "status =%d",status); status = SearchSfid(Adapter, uiSFId); - if(status>NO_OF_QUEUES) - { + if (status >= NO_OF_QUEUES) { BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "SFID %d not present in queue !!!", uiSFId ); return -EINVAL; } |