From 7bc7300b2efa1c4935acfaf63e229711745db07c Mon Sep 17 00:00:00 2001 From: Ioana Radulescu Date: Thu, 31 Jan 2013 23:56:08 +0000 Subject: dpaa_eth: Fix error in sysfs Trying to dump the MAC registers for MACless interfaces resulted in a segmentation fault. Just print a message for the user instead of accessing non-existent regs. Change-Id: I425390fbdf6aa67fa96568a8861576b8706123e7 Signed-off-by: Ioana Radulescu (cherry picked from commit 86023a9fb24fc56c0e5b9fa76b9ef2ce57f0e013) Reviewed-on: http://git.am.freescale.net:8181/1048 Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING diff --git a/drivers/net/ethernet/freescale/dpa/dpaa_eth_sysfs.c b/drivers/net/ethernet/freescale/dpa/dpaa_eth_sysfs.c index 413f27f..1a75354 100644 --- a/drivers/net/ethernet/freescale/dpa/dpaa_eth_sysfs.c +++ b/drivers/net/ethernet/freescale/dpa/dpaa_eth_sysfs.c @@ -143,7 +143,10 @@ static ssize_t dpaa_eth_show_mac_regs(struct device *dev, struct dpa_priv_s *priv = netdev_priv(to_net_dev(dev)); struct mac_device *mac_dev = priv->mac_dev; - fm_mac_dump_regs(mac_dev); + if (mac_dev) + fm_mac_dump_regs(mac_dev); + else + return sprintf(buf, "no mac registers\n"); return 0; } -- cgit v0.10.2