From 3d12cf4b3b1786444418a2aaa62754801b176eda Mon Sep 17 00:00:00 2001 From: Madalin Bucur Date: Fri, 21 Feb 2014 18:35:48 +0200 Subject: dpaa_eth: addressed several sparse reports in dpaa_ethtool.c Solved several sparse warnings in dpaa_ethtool.c. Signed-off-by: Madalin Bucur Change-Id: I612785dc4839b6377a768e823b2eae9898e6b9e4 Reviewed-on: http://git.am.freescale.net:8181/9030 Tested-by: Review Code-CDREVIEW Reviewed-by: Cristian-Constantin Sovaiala (cherry picked from commit 7fa30bc4adea9bbde0eb05fe507c3a9dc2a80474) Reviewed-on: http://git.am.freescale.net:8181/9194 diff --git a/drivers/net/ethernet/freescale/dpa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpa/dpaa_ethtool.c index a55783d..452ad4b 100644 --- a/drivers/net/ethernet/freescale/dpa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpa/dpaa_ethtool.c @@ -42,6 +42,7 @@ #include "dpaa_eth.h" #include "mac.h" /* struct mac_device */ +#include "dpaa_eth_common.h" static int __cold dpa_get_settings(struct net_device *net_dev, struct ethtool_cmd *et_cmd) @@ -114,17 +115,18 @@ static void __cold dpa_get_drvinfo(struct net_device *net_dev, sizeof(drvinfo->bus_info)-1)[sizeof(drvinfo->bus_info)-1] = 0; } -uint32_t __cold dpa_get_msglevel(struct net_device *net_dev) +static uint32_t __cold dpa_get_msglevel(struct net_device *net_dev) { return ((struct dpa_priv_s *)netdev_priv(net_dev))->msg_enable; } -void __cold dpa_set_msglevel(struct net_device *net_dev, uint32_t msg_enable) +static void __cold dpa_set_msglevel(struct net_device *net_dev, + uint32_t msg_enable) { ((struct dpa_priv_s *)netdev_priv(net_dev))->msg_enable = msg_enable; } -int __cold dpa_nway_reset(struct net_device *net_dev) +static int __cold dpa_nway_reset(struct net_device *net_dev) { int _errno; struct dpa_priv_s *priv; @@ -151,7 +153,7 @@ int __cold dpa_nway_reset(struct net_device *net_dev) return _errno; } -void __cold dpa_get_ringparam(struct net_device *net_dev, +static void __cold dpa_get_ringparam(struct net_device *net_dev, struct ethtool_ringparam *et_ringparam) { et_ringparam->rx_max_pending = 0; @@ -165,7 +167,7 @@ void __cold dpa_get_ringparam(struct net_device *net_dev, et_ringparam->tx_pending = 0; } -void __cold dpa_get_pauseparam(struct net_device *net_dev, +static void __cold dpa_get_pauseparam(struct net_device *net_dev, struct ethtool_pauseparam *et_pauseparam) { struct dpa_priv_s *priv; @@ -186,7 +188,7 @@ void __cold dpa_get_pauseparam(struct net_device *net_dev, et_pauseparam->tx_pause = priv->mac_dev->tx_pause; } -int __cold dpa_set_pauseparam(struct net_device *net_dev, +static int __cold dpa_set_pauseparam(struct net_device *net_dev, struct ethtool_pauseparam *et_pauseparam) { struct dpa_priv_s *priv; -- cgit v0.10.2