From a1a881aba8cb274025e84eabf7ef3a1009510b63 Mon Sep 17 00:00:00 2001 From: Cristian Sovaiala Date: Tue, 27 Aug 2013 09:29:50 +0300 Subject: dpaa_eth: Fix error message in ethtool Interfaces only get their PHYs initialized when they are first brought up, therefore running ethtool on an interface that is down prints an error message and returns with error code. Lower the print to debug mode and return non-error code. Signed-off-by: Cristian Sovaiala Change-Id: Ic4e9304cf9e6152868af74a31132e92d95713b62 Reviewed-on: http://git.am.freescale.net:8181/4259 Reviewed-by: Radulescu Ruxandra Ioana-B05472 Tested-by: Review Code-CDREVIEW Reviewed-by: Bucur Madalin-Cristian-B32716 Reviewed-by: Rivera Jose-B46482 Reviewed-on: http://git.am.freescale.net:8181/4466 Reviewed-by: Sovaiala Cristian-Constantin-B39531 diff --git a/drivers/net/ethernet/freescale/dpa/dpa-ethtool.c b/drivers/net/ethernet/freescale/dpa/dpa-ethtool.c index 37b8cae..5eece2f 100644 --- a/drivers/net/ethernet/freescale/dpa/dpa-ethtool.c +++ b/drivers/net/ethernet/freescale/dpa/dpa-ethtool.c @@ -50,8 +50,8 @@ static int __cold dpa_get_settings(struct net_device *net_dev, return -ENODEV; } if (unlikely(priv->mac_dev->phy_dev == NULL)) { - netdev_err(net_dev, "phy device not initialized\n"); - return -ENODEV; + netdev_dbg(net_dev, "phy device not initialized\n"); + return 0; } _errno = phy_ethtool_gset(priv->mac_dev->phy_dev, et_cmd); -- cgit v0.10.2