From 6b5dfd16cb6e8e595d4d12f944808d390f2489a4 Mon Sep 17 00:00:00 2001 From: Xiubo Li Date: Wed, 24 Sep 2014 13:51:13 +0800 Subject: watchdog: Get rid of MODULE_ALIAS_MISCDEV statements I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR) and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements. Either the device is enumerated and the driver already has a module alias (e.g. PCI, USB etc.) that will get the right driver loaded automatically. Or the device is not enumerated and loading its driver will lead to more or less intrusive hardware poking. Such hardware poking should be limited to a bare minimum, so the user should really decide which drivers should be tried and in what order. Trying them all in arbitrary order can't do any good. On top of that, loading that many drivers at once bloats the kernel log. Also many drivers will stay loaded afterward, bloating the output of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets loaded as a dependency) can't even be unloaded! If defining char-major-10-130 is needed then it should happen in user-space. Signed-off-by: Jean Delvare Acked-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Cc: Stephen Warren Cc: Mike Frysinger Cc: Wan ZongShun Cc: Ben Dooks Cc: Kukjin Kim Cc: Zwane Mwaikambo Cc: Jim Cromie --- This patch is pulled back from upstream: commit 487722cf2d66126338217896642bd5eec832c34b Change-Id: I41ef1836903d85ee832a2486ee75d5cd7eecb369 Reviewed-on: http://git.am.freescale.net:8181/21406 Tested-by: Review Code-CDREVIEW Reviewed-by: Dongsheng Wang Reviewed-by: Zhengxiong Jin diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c index 84ade6e..76fa724 100644 --- a/drivers/watchdog/imx2_wdt.c +++ b/drivers/watchdog/imx2_wdt.c @@ -357,5 +357,4 @@ module_platform_driver_probe(imx2_wdt_driver, imx2_wdt_probe); MODULE_AUTHOR("Wolfram Sang"); MODULE_DESCRIPTION("Watchdog driver for IMX2 and later"); MODULE_LICENSE("GPL v2"); -MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); MODULE_ALIAS("platform:" DRIVER_NAME); -- cgit v0.10.2