From 9873ebcac9cdc111804fbdca447f5063f074f00e Mon Sep 17 00:00:00 2001 From: Ben Hutchings Date: Sat, 28 Jun 2014 23:34:48 +0100 Subject: Fix latency histogram after "hrtimer: Set expiry time before switch_hrtimer_base()" In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, __hrtimer_start_range_ns() now crashes, as new_base is not assigned before it is used. Tested-by: Carsten Emde Cc: stable-rt@vger.kernel.org Signed-off-by: Ben Hutchings Signed-off-by: Steven Rostedt diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index bc0e47d..c967b71 100644 --- a/kernel/hrtimer.c +++ b/kernel/hrtimer.c @@ -1105,6 +1105,11 @@ int __hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim, #endif } + hrtimer_set_expires_range_ns(timer, tim, delta_ns); + + /* Switch the timer base, if necessary: */ + new_base = switch_hrtimer_base(timer, base, mode & HRTIMER_MODE_PINNED); + #ifdef CONFIG_MISSED_TIMER_OFFSETS_HIST { ktime_t now = new_base->get_time(); @@ -1116,11 +1121,6 @@ int __hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim, } #endif - hrtimer_set_expires_range_ns(timer, tim, delta_ns); - - /* Switch the timer base, if necessary: */ - new_base = switch_hrtimer_base(timer, base, mode & HRTIMER_MODE_PINNED); - timer_stats_hrtimer_set_start_info(timer); leftmost = enqueue_hrtimer(timer, new_base); -- cgit v0.10.2