From 90f84825dc383996b204297a318e2cf6c73909b0 Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Thu, 24 Apr 2014 20:05:20 +0200 Subject: crypto: caam - Kill SPRINTFCAT() with fire This macro is just like an encyclopedia of string handling done wrong. This must die. This is so wrong on so many levels. Signed-off-by: Marek Vasut Cc: Herbert Xu Cc: Horia Geanta Signed-off-by: Herbert Xu (cherry picked from commit e22cdcfa13d9799ea46245946ae09b4a328ff27d) diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c index 66a7461..7ed2e4f 100644 --- a/drivers/crypto/caam/error.c +++ b/drivers/crypto/caam/error.c @@ -158,16 +158,6 @@ static const char * const rng_err_id_list[] = { "Secure key generation", }; -#define SPRINTFCAT(str, format, param, max_alloc) \ -{ \ - char *tmp; \ - \ - tmp = kmalloc(sizeof(format) + max_alloc, GFP_ATOMIC); \ - sprintf(tmp, format, param); \ - strcat(str, tmp); \ - kfree(tmp); \ -} - static void report_ccb_status(struct device *jrdev, u32 status, const char *error, char *__outstr) { -- cgit v0.10.2