diff options
author | Amitoj Kaur Chawla <amitoj1606@gmail.com> | 2016-02-25 13:55:04 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-12 06:09:09 (GMT) |
commit | 0969e3d46b7cae0d52ba14e8901105d3cb421eb1 (patch) | |
tree | bc1a71d042e3ae554191dd7482f6cfd5ed936705 /drivers/staging/android/ion/tegra/tegra_ion.c | |
parent | dd28473385e78f94456fc66bd05c9d6db3febe13 (diff) | |
download | linux-0969e3d46b7cae0d52ba14e8901105d3cb421eb1.tar.xz |
staging: android: ion: tegra: Use devm_kcalloc instead of devm_kzalloc
Replace devm_kzalloc with devm_kcalloc to ensure there are no integer
overflows from the multiplication of a number * sizeof.
The following Coccinelle semantic patch was used to make this change:
//<smpl>
@@
expression dev,E1,E3;
type T;
@@
- devm_kzalloc(dev,E1*sizeof(T),E3)
+ devm_kcalloc(dev,E1,sizeof(T),E3)
//</smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/android/ion/tegra/tegra_ion.c')
-rw-r--r-- | drivers/staging/android/ion/tegra/tegra_ion.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/staging/android/ion/tegra/tegra_ion.c b/drivers/staging/android/ion/tegra/tegra_ion.c index 4d3c516..8828524 100644 --- a/drivers/staging/android/ion/tegra/tegra_ion.c +++ b/drivers/staging/android/ion/tegra/tegra_ion.c @@ -33,9 +33,8 @@ static int tegra_ion_probe(struct platform_device *pdev) num_heaps = pdata->nr; - heaps = devm_kzalloc(&pdev->dev, - sizeof(struct ion_heap *) * pdata->nr, - GFP_KERNEL); + heaps = devm_kcalloc(&pdev->dev, pdata->nr, + sizeof(struct ion_heap *), GFP_KERNEL); idev = ion_device_create(NULL); if (IS_ERR_OR_NULL(idev)) |