diff options
author | Ian Abbott <abbotti@mev.co.uk> | 2013-03-15 13:39:52 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-15 16:17:21 (GMT) |
commit | a14592896023adcab12307774c89284ce0744ce2 (patch) | |
tree | 3892b0b3a842bb9562516886ae4bcce39e73dce8 /drivers/staging/iio/adc/Kconfig | |
parent | 84b44d08993ffe762d9a86ee2243239350b871a4 (diff) | |
download | linux-a14592896023adcab12307774c89284ce0744ce2.tar.xz |
staging: comedi: ni_labpc: fix common detach
`labpc_common_detach()` calls `comedi_pci_disable()` unconditionally.
That's okay for PCI devices and harmless for ISA devices (as the
`hw_dev` member will be NULL so `comedi_to_pci_dev()` will return NULL
and `comedi_pci_disable()` checks for that), but it is disastrous for
PCMCIA devices. Those are managed by the "ni_labpc_cs" module but it
calls this `labpc_common_detach()` and the `hw_dev` member will be
pointing to the `struct device` embedded in a `struct pcmcia_device` in
that case. That's enough to confuse `comedi_pci_disable()` into
thinking it's a valid PCI device to be disabled.
Use the private board information (`thisboard`) to make sure it is a PCI
device before calling `comedi_pci_disable()`.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/iio/adc/Kconfig')
0 files changed, 0 insertions, 0 deletions