From 870ce49022d1a278e441d2cb7b92acae2416b510 Mon Sep 17 00:00:00 2001 From: Allen Hubbe Date: Tue, 11 Aug 2015 04:05:42 -0400 Subject: dmaengine: ioatdma: fix u16 overflow in reshape If the allocation order is 16, then the u16 index will overflow and wrap to zero instead of being equal or greater than 1 << 16. The loop condition will always be true, and the loop will run until all the memory resources are depleted. Change the type of index 'i' to u32, so that it is large enough to store a value equal or greater than 1 << 16. Signed-off-by: Allen Hubbe Acked-by: Dave Jiang Signed-off-by: Vinod Koul diff --git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c index 69c7dfc..13fbd9d 100644 --- a/drivers/dma/ioat/dma_v2.c +++ b/drivers/dma/ioat/dma_v2.c @@ -588,7 +588,7 @@ bool reshape_ring(struct ioat2_dma_chan *ioat, int order) const u16 active = ioat2_ring_active(ioat); const u32 new_size = 1 << order; struct ioat_ring_ent **ring; - u16 i; + u32 i; if (order > ioat_get_max_alloc_order()) return false; -- cgit v0.10.2