From 96b2a45c66fdca543cd94da3aa2c2542b11b9188 Mon Sep 17 00:00:00 2001 From: Mark Brown Date: Wed, 20 Apr 2016 10:16:35 +0100 Subject: eeprom: at25: Fix SPI device leak The at25 driver is using spi_dev_get() apparently just to take a copy of the SPI device used to instantiate it but never calls spi_dev_put() to free it. Since the device is guaranteed to exist between probe() and remove() there should be no need for the driver to take an extra reference to it so fix the leak by just using a straight assignment. Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c index a2858b3..2c6c7c8 100644 --- a/drivers/misc/eeprom/at25.c +++ b/drivers/misc/eeprom/at25.c @@ -345,7 +345,7 @@ static int at25_probe(struct spi_device *spi) mutex_init(&at25->lock); at25->chip = chip; - at25->spi = spi_dev_get(spi); + at25->spi = spi; spi_set_drvdata(spi, at25); at25->addrlen = addrlen; -- cgit v0.10.2