summaryrefslogtreecommitdiff
path: root/include/configs/omap3_logic.h
diff options
context:
space:
mode:
authorNishanth Menon <nm@ti.com>2016-10-11 17:39:05 (GMT)
committerTom Rini <trini@konsulko.com>2016-10-31 14:12:21 (GMT)
commit7774e97aa77c1fc18283a1ee1bfb9bdf7c6a14f2 (patch)
treeca27bb46cf4f2d5b4c2900ffafba805649407005 /include/configs/omap3_logic.h
parent2a78c9e7196ff49bdf53d0b88b49b5eb337461fe (diff)
downloadu-boot-7774e97aa77c1fc18283a1ee1bfb9bdf7c6a14f2.tar.xz
ti: common: board_detect: Return a valid empty string for un-initialized eeprom
Current logic for query of revision, board_name, config returns NULL. Users of these functions do a direct strncmp to compare. Unfortunately, as per conventions require two valid strings to compare against and the current implementation causes a crash when compared with NULL. We'd still like to maintain the simplistic usage of these APIs instead of redundant if (string) res=strncmp(fn(),"cmp",n); flowing all over the place. Hence, since the version, name and config is already pre-initialized with empty string, just dont check for invalid header in the first place and return the empty string to the caller. Reported-by: Brad Griffis <bgriffis@ti.com> Signed-off-by: Nishanth Menon <nm@ti.com> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> Reviewed-by: Tom Rini <trini@konsulko.com> [trini: Correct was'nt -> wasn't typo] Signed-off-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'include/configs/omap3_logic.h')
0 files changed, 0 insertions, 0 deletions