From 65e8ce29e4efc7f1716828ec845bd294a942e1ca Mon Sep 17 00:00:00 2001 From: "xypron.glpk@gmx.de" Date: Sun, 30 Jul 2017 20:22:47 +0200 Subject: arm: bcm235xx: clk_set_rate avoid possible NULL deref It does not make sense first to dereference c and then to check if it is NULL. Signed-off-by: Heinrich Schuchardt diff --git a/arch/arm/cpu/armv7/bcm235xx/clk-core.c b/arch/arm/cpu/armv7/bcm235xx/clk-core.c index ee4b345..89e367b 100644 --- a/arch/arm/cpu/armv7/bcm235xx/clk-core.c +++ b/arch/arm/cpu/armv7/bcm235xx/clk-core.c @@ -493,9 +493,9 @@ int clk_set_rate(struct clk *c, unsigned long rate) { int ret; - debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (!c || !c->ops || !c->ops->set_rate) return -EINVAL; + debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (c->use_cnt) return -EINVAL; -- cgit v0.10.2