From c0e6723ee4b98fa0bda48028568bc3f853682567 Mon Sep 17 00:00:00 2001 From: Sven Schnelle Date: Tue, 4 Oct 2011 21:53:32 +0200 Subject: AVR32: fix timer_init() function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit timer_init() now returns an int (the error code) instead of void. This makes compilation fail with: interrupts.c:111: error: conflicting types for 'timer_init' /home/svens/u-boot/u-boot/include/common.h:246: error: previous declaration of 'timer_init' was here make[1]: *** [interrupts.o] Error 1 Signed-off-by: Sven Schnelle Acked-by: Andreas Bießmann Signed-off-by: Anatolij Gustschin diff --git a/arch/avr32/cpu/interrupts.c b/arch/avr32/cpu/interrupts.c index 6681e13..49a00f1 100644 --- a/arch/avr32/cpu/interrupts.c +++ b/arch/avr32/cpu/interrupts.c @@ -107,7 +107,7 @@ static int set_interrupt_handler(unsigned int nr, void (*handler)(void), return 0; } -void timer_init(void) +int timer_init(void) { extern void timer_interrupt_handler(void); u64 tmp; @@ -120,8 +120,9 @@ void timer_init(void) tb_factor = (u32)tmp; if (set_interrupt_handler(0, &timer_interrupt_handler, 3)) - return; + return -EINVAL; /* For all practical purposes, this gives us an overflow interrupt */ sysreg_write(COMPARE, 0xffffffff); + return 0; } -- cgit v0.10.2 From 43d4a5e687fe530d641227910d5e8f1514228eff Mon Sep 17 00:00:00 2001 From: Heiko Schocher Date: Mon, 12 Dec 2011 20:37:17 +0000 Subject: common/cmd_pxe.c: Fix GCC 4.6 build warnings Fix: cmd_pxe.c: In function 'parse_pxefile_top': cmd_pxe.c:941:5: warning: 'err' may be used uninitialized in this function [-Wuninitialized] cmd_pxe.c:921:6: note: 'err' was declared here Signed-off-by: Heiko Schocher Cc: Jason Hobbs Acked-by: Jason Hobbs diff --git a/common/cmd_pxe.c b/common/cmd_pxe.c index 9426f5b..7c0cb66 100644 --- a/common/cmd_pxe.c +++ b/common/cmd_pxe.c @@ -918,7 +918,7 @@ static int parse_menu(char **c, struct pxe_menu *cfg, char *b, int nest_level) { struct token t; char *s = *c; - int err; + int err = 0; get_token(c, &t, L_KEYWORD); -- cgit v0.10.2