diff options
| author | Cristian Sovaiala <cristian.sovaiala@freescale.com> | 2013-08-27 06:29:50 (GMT) |
|---|---|---|
| committer | Rivera Jose-B46482 <German.Rivera@freescale.com> | 2013-09-10 23:16:36 (GMT) |
| commit | a1a881aba8cb274025e84eabf7ef3a1009510b63 (patch) | |
| tree | 96751e881e8656ce5548254ff01e28d042bb97cd | |
| parent | aecc09b49397ce49ddb4b8e77e938b814b20063c (diff) | |
| download | linux-fsl-qoriq-a1a881aba8cb274025e84eabf7ef3a1009510b63.tar.xz | |
dpaa_eth: Fix error message in ethtool
Interfaces only get their PHYs initialized when they are first
brought up, therefore running ethtool on an interface that is down
prints an error message and returns with error code.
Lower the print to debug mode and return non-error code.
Signed-off-by: Cristian Sovaiala <cristian.sovaiala@freescale.com>
Change-Id: Ic4e9304cf9e6152868af74a31132e92d95713b62
Reviewed-on: http://git.am.freescale.net:8181/4259
Reviewed-by: Radulescu Ruxandra Ioana-B05472 <ruxandra.radulescu@freescale.com>
Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
Reviewed-by: Bucur Madalin-Cristian-B32716 <madalin.bucur@freescale.com>
Reviewed-by: Rivera Jose-B46482 <German.Rivera@freescale.com>
Reviewed-on: http://git.am.freescale.net:8181/4466
Reviewed-by: Sovaiala Cristian-Constantin-B39531 <Cristian.Sovaiala@freescale.com>
| -rw-r--r-- | drivers/net/ethernet/freescale/dpa/dpa-ethtool.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/freescale/dpa/dpa-ethtool.c b/drivers/net/ethernet/freescale/dpa/dpa-ethtool.c index 37b8cae..5eece2f 100644 --- a/drivers/net/ethernet/freescale/dpa/dpa-ethtool.c +++ b/drivers/net/ethernet/freescale/dpa/dpa-ethtool.c @@ -50,8 +50,8 @@ static int __cold dpa_get_settings(struct net_device *net_dev, return -ENODEV; } if (unlikely(priv->mac_dev->phy_dev == NULL)) { - netdev_err(net_dev, "phy device not initialized\n"); - return -ENODEV; + netdev_dbg(net_dev, "phy device not initialized\n"); + return 0; } _errno = phy_ethtool_gset(priv->mac_dev->phy_dev, et_cmd); |