summaryrefslogtreecommitdiff
path: root/drivers/char/ipmi
diff options
context:
space:
mode:
authorPeter Huewe <PeterHuewe@gmx.de>2013-10-29 23:54:20 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-02-06 19:22:18 (GMT)
commite0383660eb2692180b23a8b833fd8b13c602de28 (patch)
tree98434fd55dd6f19b718f539e6d7f0632a9e81024 /drivers/char/ipmi
parent898e49a224c935709db86fada5dce191b5777a1d (diff)
downloadlinux-fsl-qoriq-e0383660eb2692180b23a8b833fd8b13c602de28.tar.xz
tpm/tpm_i2c_stm_st33: Check return code of get_burstcount
commit 85c5e0d451125c6ddb78663972e40af810b83644 upstream. The 'get_burstcount' function can in some circumstances 'return -EBUSY' which in tpm_stm_i2c_send is stored in an 'u32 burstcnt' thus converting the signed value into an unsigned value, resulting in 'burstcnt' being huge. Changing the type to u32 only does not solve the problem as the signed value is converted to an unsigned in I2C_WRITE_DATA, resulting in the same effect. Thus -> Change type of burstcnt to u32 (the return type of get_burstcount) -> Add a check for the return value of 'get_burstcount' and propagate a potential error. This makes also sense in the 'I2C_READ_DATA' case, where the there is no signed/unsigned conversion. found by coverity Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char/ipmi')
0 files changed, 0 insertions, 0 deletions