diff options
| author | Alan Cox <alan@linux.intel.com> | 2012-10-11 16:21:03 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-22 22:44:30 (GMT) |
| commit | 720a9bece0c132a9095e997969f07d8694816bbc (patch) | |
| tree | ed6191135ba3b3806c2e7508f264f7c9f34d609c /drivers/staging/dgrp/dgrp_net_ops.c | |
| parent | 69afc09042290807b4a8d2756f1fc3b49ff269ee (diff) | |
| download | linux-fsl-qoriq-720a9bece0c132a9095e997969f07d8694816bbc.tar.xz | |
staging: dgrp: fix some warnings
Just squashing these to get them out of the analysis queue.
nd_ps_desc is an array not a pointer so comparing it with NULL is silly (be
nice if gcc shouted about this). And there are some slightly pointless
comparisons too.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/dgrp/dgrp_net_ops.c')
| -rw-r--r-- | drivers/staging/dgrp/dgrp_net_ops.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/staging/dgrp/dgrp_net_ops.c b/drivers/staging/dgrp/dgrp_net_ops.c index ab839ea..067d975 100644 --- a/drivers/staging/dgrp/dgrp_net_ops.c +++ b/drivers/staging/dgrp/dgrp_net_ops.c @@ -1671,6 +1671,9 @@ static int dgrp_send(struct nd_struct *nd, long tmax) * do the job. */ + /* FIXME: jiffies - ch->ch_waketime can never + be < 0. Someone needs to work out what is + actually intended here */ if (ch->ch_pun.un_open_count && (ch->ch_pun.un_flag & (UN_EMPTY|UN_TIME|UN_LOW|UN_PWAIT)) != 0) { |