diff options
| author | Julia Lawall <julia@diku.dk> | 2010-05-15 21:21:43 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-17 23:31:15 (GMT) |
| commit | 94002c07ff0e207a883519ccc35c0b5390b29331 (patch) | |
| tree | b730a75ef2ad76d1e3a322e5982b30ca46b6c487 /drivers/staging/line6/pod.c | |
| parent | 96fe9ee2c2dfe3268961f3873ea6098b9b9f27c2 (diff) | |
| download | linux-fsl-qoriq-94002c07ff0e207a883519ccc35c0b5390b29331.tar.xz | |
Staging: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the
allocated region.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/line6/pod.c')
| -rw-r--r-- | drivers/staging/line6/pod.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 4983f2b..28f5146 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c @@ -1074,7 +1074,8 @@ int pod_init(struct usb_interface *interface, struct usb_line6_pod *pod) return -ENOMEM; } - pod->buffer_versionreq = kmalloc(sizeof(pod_request_version), + pod->buffer_versionreq = kmemdup(pod_request_version, + sizeof(pod_request_version), GFP_KERNEL); if (pod->buffer_versionreq == NULL) { @@ -1083,9 +1084,6 @@ int pod_init(struct usb_interface *interface, struct usb_line6_pod *pod) return -ENOMEM; } - memcpy(pod->buffer_versionreq, pod_request_version, - sizeof(pod_request_version)); - /* create sysfs entries: */ err = pod_create_files2(&interface->dev); if (err < 0) { |