summaryrefslogtreecommitdiff
path: root/drivers/staging/rts5139
diff options
context:
space:
mode:
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>2013-04-19 11:35:45 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-04-19 18:17:15 (GMT)
commit3a8d2ccdcff80c2a0aa2367cc4855c7f57e13a06 (patch)
tree0c2da221a501e17497b78dcd8e61d52996023ded /drivers/staging/rts5139
parentf33cb17d1dd68d78accf46db96ced2dc7b4563c3 (diff)
downloadlinux-fsl-qoriq-3a8d2ccdcff80c2a0aa2367cc4855c7f57e13a06.tar.xz
staging: rts5129: re-use kbasename()
The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. The __FILE__ macro always defined if we compile an existing file. Thus, NULL check is not needed there as well. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rts5139')
-rw-r--r--drivers/staging/rts5139/trace.h24
1 files changed, 4 insertions, 20 deletions
diff --git a/drivers/staging/rts5139/trace.h b/drivers/staging/rts5139/trace.h
index c9dfb1e..ac58b45 100644
--- a/drivers/staging/rts5139/trace.h
+++ b/drivers/staging/rts5139/trace.h
@@ -27,32 +27,16 @@
#ifndef __RTS51X_TRACE_H
#define __RTS51X_TRACE_H
+#include <linux/string.h>
+
#include "debug.h"
#define _MSG_TRACE
#ifdef _MSG_TRACE
-static inline char *filename(char *path)
-{
- char *ptr;
-
- if (path == NULL)
- return NULL;
-
- ptr = path;
-
- while (*ptr != '\0') {
- if ((*ptr == '\\') || (*ptr == '/'))
- path = ptr + 1;
- ptr++;
- }
-
- return path;
-}
-
#define TRACE_RET(chip, ret) \
do { \
- char *_file = filename((char *)__FILE__); \
+ const char *_file = kbasename(__FILE__); \
RTS51X_DEBUGP("[%s][%s]:[%d]\n", _file, __func__, __LINE__); \
(chip)->trace_msg[(chip)->msg_idx].line = (u16)(__LINE__); \
strncpy((chip)->trace_msg[(chip)->msg_idx].func, \
@@ -71,7 +55,7 @@ do { \
#define TRACE_GOTO(chip, label) \
do { \
- char *_file = filename((char *)__FILE__); \
+ const char *_file = kbasename(__FILE__); \
RTS51X_DEBUGP("[%s][%s]:[%d]\n", _file, __func__, __LINE__); \
(chip)->trace_msg[(chip)->msg_idx].line = (u16)(__LINE__); \
strncpy((chip)->trace_msg[(chip)->msg_idx].func, \