summaryrefslogtreecommitdiff
path: root/drivers/usb/chipidea
diff options
context:
space:
mode:
authorMichael Grzeschik <m.grzeschik@pengutronix.de>2012-05-11 14:25:50 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-05-11 23:54:11 (GMT)
commitb9322252727bc3af6e64b8d75058403edeaddea5 (patch)
tree0459830fdcb9a86d071fb914348e91b211759ce6 /drivers/usb/chipidea
parent551a8ac64e4ea9e9e2b8656ee3bf94c8d0821d41 (diff)
downloadlinux-fsl-qoriq-b9322252727bc3af6e64b8d75058403edeaddea5.tar.xz
usb: chipidea: isr_reset_handler fix missing locking
Move spin_lock under the done label, so the lock will also be pulled in the error paths. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> [rebased on top of the patchset] Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/chipidea')
-rw-r--r--drivers/usb/chipidea/udc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 9133a59..ddd27d3 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -645,9 +645,9 @@ __acquires(udc->lock)
if (udc->status == NULL)
retval = -ENOMEM;
+done:
spin_lock(&udc->lock);
- done:
if (retval)
dev_err(udc->dev, "error: %i\n", retval);
}