summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorH Hartley Sweeten <hsweeten@visionengravers.com>2013-06-04 02:04:03 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-06-05 22:35:38 (GMT)
commit4b2ebd8dea7f0cf20ce3cccc45a60dfb7853b3ea (patch)
tree3825f52191bdf134fd5fdee3d2d5f63002dabcee /drivers
parentd6b354d21a7e8d91a1b54e3532a8bf35c54ce272 (diff)
downloadlinux-fsl-qoriq-4b2ebd8dea7f0cf20ce3cccc45a60dfb7853b3ea.tar.xz
staging: comedi: pcmda12: tidy up subdevice init
For aesthetic reasons. add some whitespace to the subdevice init and reorder it a bit. Remove the 's->private = NULL', it was kzalloc'ed by the core and will already be NULL. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/staging/comedi/drivers/pcmda12.c15
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/staging/comedi/drivers/pcmda12.c b/drivers/staging/comedi/drivers/pcmda12.c
index dfd2bff..c725a9b 100644
--- a/drivers/staging/comedi/drivers/pcmda12.c
+++ b/drivers/staging/comedi/drivers/pcmda12.c
@@ -167,14 +167,13 @@ static int pcmda12_attach(struct comedi_device *dev,
return ret;
s = &dev->subdevices[0];
- s->private = NULL;
- s->maxdata = 0x0fff;
- s->range_table = &pcmda12_ranges;
- s->type = COMEDI_SUBD_AO;
- s->subdev_flags = SDF_READABLE | SDF_WRITABLE;
- s->n_chan = CHANS;
- s->insn_write = &ao_winsn;
- s->insn_read = &ao_rinsn;
+ s->type = COMEDI_SUBD_AO;
+ s->subdev_flags = SDF_READABLE | SDF_WRITABLE;
+ s->n_chan = CHANS;
+ s->maxdata = 0x0fff;
+ s->range_table = &pcmda12_ranges;
+ s->insn_write = &ao_winsn;
+ s->insn_read = &ao_rinsn;
zero_chans(dev); /* clear out all the registers, basically */