summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2012-12-03 10:07:14 (GMT)
committerDavid S. Miller <davem@davemloft.net>2012-12-03 20:07:36 (GMT)
commit5d097109257c03a71845729f8db6b5770c4bbedc (patch)
tree4ef14ea47b21f6f81412c95889ca30147e0f0458 /kernel
parent9ba2add3cf5c103b7236f82a023c8ee05a51e4d1 (diff)
downloadlinux-fsl-qoriq-5d097109257c03a71845729f8db6b5770c4bbedc.tar.xz
tun: only queue packets on device
Historically tun supported two modes of operation: - in default mode, a small number of packets would get queued at the device, the rest would be queued in qdisc - in one queue mode, all packets would get queued at the device This might have made sense up to a point where we made the queue depth for both modes the same and set it to a huge value (500) so unless the consumer is stuck the chance of losing packets is small. Thus in practice both modes behave the same, but the default mode has some problems: - if packets are never consumed, fragments are never orphaned which cases a DOS for sender using zero copy transmit - overrun errors are hard to diagnose: fifo error is incremented only once so you can not distinguish between userspace that is stuck and a transient failure, tcpdump on the device does not show any traffic Userspace solves this simply by enabling IFF_ONE_QUEUE but there seems to be little point in not doing the right thing for everyone, by default. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions