diff options
author | Vivek Goyal <vgoyal@in.ibm.com> | 2006-01-10 04:51:44 (GMT) |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-01-10 16:01:27 (GMT) |
commit | e996e58133c475bcf3a229f716b9457267cbaa0a (patch) | |
tree | 9fd2f41d7e2c0deaca71a88a1b36d873ede3c7b8 /kernel | |
parent | 35ed319a36cdfd88fc3debe6ce24e756bc474cce (diff) | |
download | linux-fsl-qoriq-e996e58133c475bcf3a229f716b9457267cbaa0a.tar.xz |
[PATCH] kdump: save registers early (inline functions)
- If system panics then cpu register states are captured through funciton
crash_get_current_regs(). This is not a inline function hence a stack frame
is pushed on to the stack and then cpu register state is captured. Later
this frame is popped and new frames are pushed (machine_kexec).
- In theory this is not very right as we are capturing register states for a
frame and that frame is no more valid. This seems to have created back
trace problems for ppc64.
- This patch fixes it up. The very first thing it does after entering
crash_kexec() is to capture the register states. Anyway we don't want the
back trace beyond crash_kexec(). crash_get_current_regs() has been made
inline
- crash_setup_regs() is the top architecture dependent function which should
be responsible for capturing the register states as well as to do some
architecture dependent tricks. For ex. fixing up ss and esp for i386.
crash_setup_regs() has also been made inline to ensure no new call frame is
pushed onto stack.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/kexec.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/kexec.c b/kernel/kexec.c index 1197de8..de14416 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -1057,7 +1057,9 @@ void crash_kexec(struct pt_regs *regs) if (!locked) { image = xchg(&kexec_crash_image, NULL); if (image) { - machine_crash_shutdown(regs); + struct pt_regs fixed_regs; + crash_setup_regs(&fixed_regs, regs); + machine_crash_shutdown(&fixed_regs); machine_kexec(image); } xchg(&kexec_lock, 0); |