summaryrefslogtreecommitdiff
path: root/net/can
diff options
context:
space:
mode:
authorDaniel Halperin <dhalperi@cs.washington.edu>2010-05-25 17:22:49 (GMT)
committerReinette Chatre <reinette.chatre@intel.com>2010-06-06 06:21:26 (GMT)
commitf668da2f150948a961d359c65b5e9d62da1290e2 (patch)
treeb0d23bd8b858751b5e0af473c521945185cf9acf /net/can
parent02cd8dee6e10d6ab7161a3c6f36a60f8894fafdd (diff)
downloadlinux-fsl-qoriq-f668da2f150948a961d359c65b5e9d62da1290e2.tar.xz
iwlwifi: fix wrapping when handling aggregated batches
Fairly complex code in iwlagn_tx_status_reply_tx handle the status reports for aggregated packet batches sent by the NIC. This code aims to handle the case where the NIC retransmits failed packets from a previous batch; the status information for these packets can sometimes be inserted in the middle of a batch and are actually not in order by sequence number! (I verified this can happen with printk's in the function.) The code in question adaptively identifies the "first" frame of the batch, taking into account that it may not be the one corresponding to the first agg status report, and also handles the case when the set of sent packets wraps the 256-character entry buffer. It generates the agg->bitmap field of sent packets which is later compared to the BlockAck response from the receiver to see which frames of those sent in this batch were ACKed. A small logic error (wrapping by 0xff==255 instead of 0x100==256) was causing the agg->bitmap to be set incorrectly. Fix this wrapping code, and add extensive comments to clarify what is going on. Signed-off-by: Daniel Halperin <dhalperi@cs.washington.edu> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Diffstat (limited to 'net/can')
0 files changed, 0 insertions, 0 deletions