diff options
author | Joe Perches <joe@perches.com> | 2012-05-08 18:56:55 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-05-10 00:49:19 (GMT) |
commit | ac422d3cc25351819ec80b7e2852fd2c600c317c (patch) | |
tree | a6ca456ad41256bf2cee71a189c1c05027f16532 /net/wireless/wext-spy.c | |
parent | 8561cf99785faf73cccb9f417170d8b5844bf496 (diff) | |
download | linux-fsl-qoriq-ac422d3cc25351819ec80b7e2852fd2c600c317c.tar.xz |
wireless: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.
I removed a conversion from scan.c/cmp_bss_core
that appears to be a sorting function.
Done via cocci script:
$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
- !compare_ether_addr(a, b)
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- compare_ether_addr(a, b)
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) == 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) != 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/wireless/wext-spy.c')
-rw-r--r-- | net/wireless/wext-spy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/wireless/wext-spy.c b/net/wireless/wext-spy.c index 5d643a5..33bef22 100644 --- a/net/wireless/wext-spy.c +++ b/net/wireless/wext-spy.c @@ -203,7 +203,7 @@ void wireless_spy_update(struct net_device * dev, /* Update all records that match */ for (i = 0; i < spydata->spy_number; i++) - if (!compare_ether_addr(address, spydata->spy_address[i])) { + if (ether_addr_equal(address, spydata->spy_address[i])) { memcpy(&(spydata->spy_stat[i]), wstats, sizeof(struct iw_quality)); match = i; |