From e141d6c63c46ca39ae7fff2e200a55cb2b00e4fb Mon Sep 17 00:00:00 2001
From: Cristian Bercaru <cristian.bercaru@freescale.com>
Date: Wed, 14 Aug 2013 16:34:56 +0300
Subject: dpaa_eth: fix coccinelle code analysis issues

Assign boolean constants to boolean variables instead of integer
constants.

Signed-off-by: Cristian Bercaru <cristian.bercaru@freescale.com>
Reviewed-on: http://git.am.freescale.net:8181/4021
Reviewed-by: Bucur Madalin-Cristian-B32716 <madalin.bucur@freescale.com>
Reviewed-by: Radulescu Ruxandra Ioana-B05472 <ruxandra.radulescu@freescale.com>
Change-Id: I7f3550f1af032349dbedfe59ae39a337195b2aff
Reviewed-on: http://git.am.freescale.net:8181/4645
Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
Reviewed-by: Bogdan Hamciuc <bogdan.hamciuc@freescale.com>
Reviewed-by: Rivera Jose-B46482 <German.Rivera@freescale.com>

diff --git a/drivers/net/ethernet/freescale/dpa/dpaa_eth_common.c b/drivers/net/ethernet/freescale/dpa/dpaa_eth_common.c
index 48c6b64..ecd8080 100644
--- a/drivers/net/ethernet/freescale/dpa/dpaa_eth_common.c
+++ b/drivers/net/ethernet/freescale/dpa/dpaa_eth_common.c
@@ -335,7 +335,7 @@ static void dpa_ts_tx_enable(struct net_device *dev)
 	if (mac_dev->ptp_enable)
 		mac_dev->ptp_enable(mac_dev->get_mac_handle(mac_dev));
 
-	priv->ts_tx_en = TRUE;
+	priv->ts_tx_en = true;
 }
 
 static void dpa_ts_tx_disable(struct net_device *dev)
@@ -355,7 +355,7 @@ static void dpa_ts_tx_disable(struct net_device *dev)
 		mac_dev->ptp_disable(mac_dev->get_mac_handle(mac_dev));
 #endif
 
-	priv->ts_tx_en = FALSE;
+	priv->ts_tx_en = false;
 }
 
 static void dpa_ts_rx_enable(struct net_device *dev)
@@ -368,7 +368,7 @@ static void dpa_ts_rx_enable(struct net_device *dev)
 	if (mac_dev->ptp_enable)
 		mac_dev->ptp_enable(mac_dev->get_mac_handle(mac_dev));
 
-	priv->ts_rx_en = TRUE;
+	priv->ts_rx_en = true;
 }
 
 static void dpa_ts_rx_disable(struct net_device *dev)
@@ -388,7 +388,7 @@ static void dpa_ts_rx_disable(struct net_device *dev)
 		mac_dev->ptp_disable(mac_dev->get_mac_handle(mac_dev));
 #endif
 
-	priv->ts_rx_en = FALSE;
+	priv->ts_rx_en = false;
 }
 
 static int dpa_ts_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
diff --git a/drivers/net/ethernet/freescale/dpa/dpaa_eth_unit_test.c b/drivers/net/ethernet/freescale/dpa/dpaa_eth_unit_test.c
index 62095a7..4856e15 100644
--- a/drivers/net/ethernet/freescale/dpa/dpaa_eth_unit_test.c
+++ b/drivers/net/ethernet/freescale/dpa/dpaa_eth_unit_test.c
@@ -283,7 +283,7 @@ static int dpa_tx_unit_test(struct net_device *net_dev)
 			}
 
 			/* Was it good? */
-			if (tx_unit_test_passed == false) {
+			if (!tx_unit_test_passed) {
 				pr_err("Test failed:\n");
 				pr_err("size: %d pad: %d head: %p end: %p\n",
 					size, headroom, tx_unit_skb_head,
diff --git a/drivers/net/ethernet/freescale/dpa/offline_port.c b/drivers/net/ethernet/freescale/dpa/offline_port.c
index c002dc9..95dd28a 100644
--- a/drivers/net/ethernet/freescale/dpa/offline_port.c
+++ b/drivers/net/ethernet/freescale/dpa/offline_port.c
@@ -134,7 +134,7 @@ oh_port_probe(struct platform_device *_of_dev)
 	uint32_t		 queues_count;
 	uint32_t		 crt_fqid_base;
 	uint32_t		 crt_fq_count;
-	bool			frag_enabled = FALSE;
+	bool			frag_enabled = false;
 	struct fm_port_params	oh_port_tx_params;
 	struct fm_port_pcd_param	oh_port_pcd_params;
 	struct dpa_buffer_layout_s buf_layout;
@@ -369,7 +369,7 @@ oh_port_probe(struct platform_device *_of_dev)
 	    buf_layout.manip_extra_space != FRAG_MANIP_SPACE)
 		goto init_port;
 
-	frag_enabled = TRUE;
+	frag_enabled = true;
 	dev_info(dpa_oh_dev, "IP Fragmentation enabled for OH port %d",
 		     *port_id);
 
-- 
cgit v0.10.2