From 504187332d5c8008c821413ea87d94b95c535545 Mon Sep 17 00:00:00 2001 From: Emil Medve Date: Fri, 17 Jan 2014 10:35:39 -0600 Subject: fsl_qbman: Replace memcpy with struct assignment This fixes the following coccinelle warning: Replace memcpy with struct assignment Signed-off-by: Emil Medve Change-Id: I38f3bf57b18f8fbb8e295ae7b46a187e52491d20 Reviewed-on: http://git.am.freescale.net:8181/8106 Tested-by: Review Code-CDREVIEW Reviewed-by: Haiying Wang Reviewed-by: Emilian Medve diff --git a/drivers/staging/fsl_qbman/fsl_usdpaa.c b/drivers/staging/fsl_qbman/fsl_usdpaa.c index f54877a..d67cbb2 100644 --- a/drivers/staging/fsl_qbman/fsl_usdpaa.c +++ b/drivers/staging/fsl_qbman/fsl_usdpaa.c @@ -1175,7 +1175,7 @@ static long ioctl_portal_map(struct file *fp, struct ctx *ctx, if (!mapping) return -ENOMEM; - memcpy(&mapping->user, arg, sizeof(mapping->user)); + mapping->user = *arg; if (mapping->user.type == usdpaa_portal_qman) { mapping->qportal = qm_get_unused_portal_idx(mapping->user.index); @@ -1213,7 +1213,7 @@ static long ioctl_portal_map(struct file *fp, struct ctx *ctx, &mapping->user.addr.cinh); if (ret) goto err_mmap_cinh; - memcpy(arg, &mapping->user, sizeof(mapping->user)); + *arg = mapping->user; return ret; err_mmap_cinh: diff --git a/drivers/staging/fsl_qbman/qman_private.h b/drivers/staging/fsl_qbman/qman_private.h index 1434a04d..92bd201 100644 --- a/drivers/staging/fsl_qbman/qman_private.h +++ b/drivers/staging/fsl_qbman/qman_private.h @@ -77,7 +77,7 @@ static inline int qman_cgrs_next(struct qman_cgrs *c, int num) static inline void qman_cgrs_cp(struct qman_cgrs *dest, const struct qman_cgrs *src) { - memcpy(dest, src, sizeof(*dest)); + *dest = *src; } static inline void qman_cgrs_and(struct qman_cgrs *dest, const struct qman_cgrs *a, const struct qman_cgrs *b) @@ -133,7 +133,7 @@ static inline int qman_ccgrs_next(struct qman_ccgrs *c, int num) static inline void qman_ccgrs_cp(struct qman_ccgrs *dest, const struct qman_ccgrs *src) { - memcpy(dest, src, sizeof(*dest)); + *dest = *src; } static inline void qman_ccgrs_and(struct qman_ccgrs *dest, const struct qman_ccgrs *a, const struct qman_ccgrs *b) -- cgit v0.10.2