diff options
| author | Bruce Allan <bruce.w.allan@intel.com> | 2009-11-20 23:23:53 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-11-21 19:33:56 (GMT) |
| commit | 98086a954a75152f8b09c131fa443205bae5fde1 (patch) | |
| tree | b80d383232de8de30301f4d7257d3eed0fa7c13e | |
| parent | 7ea9655f8a4ccefcd8fdea7eb4fc5dab98e1a7ba (diff) | |
| download | linux-fsl-qoriq-98086a954a75152f8b09c131fa443205bae5fde1.tar.xz | |
e1000e: improper return code signage
The e1000_get_cable_length_82577() should return a negative value upon
error.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/e1000e/phy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/e1000e/phy.c b/drivers/net/e1000e/phy.c index 03175b3..95a8196 100644 --- a/drivers/net/e1000e/phy.c +++ b/drivers/net/e1000e/phy.c @@ -3137,7 +3137,7 @@ s32 e1000_get_cable_length_82577(struct e1000_hw *hw) I82577_DSTATUS_CABLE_LENGTH_SHIFT; if (length == E1000_CABLE_LENGTH_UNDEFINED) - ret_val = E1000_ERR_PHY; + ret_val = -E1000_ERR_PHY; phy->cable_length = length; |