diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2011-02-09 10:28:04 (GMT) |
|---|---|---|
| committer | Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> | 2011-04-13 13:46:57 (GMT) |
| commit | c7d876321f4cf252bc70c1995bbc077a65b3af2a (patch) | |
| tree | 2900ae78fcb37756419a6be501f1740a6218dda5 | |
| parent | 9f0d15aac9987adaff18b85585fb7eaba266e112 (diff) | |
| download | linux-fsl-qoriq-c7d876321f4cf252bc70c1995bbc077a65b3af2a.tar.xz | |
don't check platform_get_irq's return value against zero
platform_get_irq returns -ENXIO on failure, so !int_irq was probably
always true. Better use (int)int_irq <= 0. Note that a return value of
zero is still handled as error even though this could mean irq0.
This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.
Acked-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
| -rw-r--r-- | arch/avr32/mach-at32ap/extint.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/avr32/mach-at32ap/extint.c b/arch/avr32/mach-at32ap/extint.c index 755ac59..fbc2aea 100644 --- a/arch/avr32/mach-at32ap/extint.c +++ b/arch/avr32/mach-at32ap/extint.c @@ -191,7 +191,7 @@ static int __init eic_probe(struct platform_device *pdev) regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); int_irq = platform_get_irq(pdev, 0); - if (!regs || !int_irq) { + if (!regs || (int)int_irq <= 0) { dev_dbg(&pdev->dev, "missing regs and/or irq resource\n"); return -ENXIO; } |