diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-09-10 22:56:35 (GMT) |
|---|---|---|
| committer | Inki Dae <inki.dae@samsung.com> | 2013-09-16 12:57:08 (GMT) |
| commit | 662bb6992a505ad41db3c8b52b1e70934507c2e2 (patch) | |
| tree | ef2016ba2ab78c0f33b1d789ae712089ac17312a /drivers/gpu | |
| parent | fafb38374bfaa92bc943fba4edf73849be2968a8 (diff) | |
| download | linux-fsl-qoriq-662bb6992a505ad41db3c8b52b1e70934507c2e2.tar.xz | |
drm/exynos: fix return value check in lowlevel_buffer_allocate()
In case of error, the function drm_prime_pages_to_sg() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_drm_buf.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c b/drivers/gpu/drm/exynos/exynos_drm_buf.c index d20a7af..9c80884 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.c @@ -91,9 +91,9 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, } buf->sgt = drm_prime_pages_to_sg(buf->pages, nr_pages); - if (!buf->sgt) { + if (IS_ERR(buf->sgt)) { DRM_ERROR("failed to get sg table.\n"); - ret = -ENOMEM; + ret = PTR_ERR(buf->sgt); goto err_free_attrs; } |