summaryrefslogtreecommitdiff
path: root/drivers/net/ixgbevf/vf.c
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2010-11-17 03:26:42 (GMT)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2010-11-17 03:26:42 (GMT)
commit1a51502bddca7ac1e921d918b741ffd2bec149ed (patch)
treeee41f3f5fdba243eb2e68b0fd8ee4c8c84d72c2b /drivers/net/ixgbevf/vf.c
parentb178bb3dfc30d9555bdd2401e95af98e23e83e10 (diff)
downloadlinux-fsl-qoriq-1a51502bddca7ac1e921d918b741ffd2bec149ed.tar.xz
ixgbe: delay rx_ring freeing
"cat /proc/net/dev" uses RCU protection only. Its quite possible we call a driver get_stats() method while device is dismantling and freeing its data structures. So get_stats() methods must be very careful not accessing driver private data without appropriate locking. In ixgbe case, we access rx_ring pointers. These pointers are freed in ixgbe_clear_interrupt_scheme() and set to NULL, this can trigger NULL dereference in ixgbe_get_stats64() A possible fix is to use RCU locking in ixgbe_get_stats64() and defer rx_ring freeing after a grace period in ixgbe_clear_interrupt_scheme() Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Reported-by: Tantilov, Emil S <emil.s.tantilov@intel.com> Tested-by: Ross Brattain <ross.b.brattain@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ixgbevf/vf.c')
0 files changed, 0 insertions, 0 deletions