diff options
author | Geert Uytterhoeven <geert+renesas@linux-m68k.org> | 2014-01-28 09:33:03 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-02-22 21:32:25 (GMT) |
commit | 9a446020f5ee8dd8d7b6522ac42933275f99d991 (patch) | |
tree | 6b760a94a69265d994ed1889bb828e3c3276dcf3 /drivers/net/wireless | |
parent | d87e47c32aad947e6ce5d3eb3ca077cabb0387b7 (diff) | |
download | linux-fsl-qoriq-9a446020f5ee8dd8d7b6522ac42933275f99d991.tar.xz |
spi: Fix crash with double message finalisation on error handling
commit 1f802f8249a0da536877842c43c7204064c4de8b upstream.
This reverts commit e120cc0dcf2880a4c5c0a6cb27b655600a1cfa1d.
It causes a NULL pointer dereference with drivers using the generic
spi_transfer_one_message(), which always calls
spi_finalize_current_message(), which zeroes master->cur_msg.
Drivers implementing transfer_one_message() theirselves must always call
spi_finalize_current_message(), even if the transfer failed:
* @transfer_one_message: the subsystem calls the driver to transfer a single
* message while queuing transfers that arrive in the meantime. When the
* driver is finished with this message, it must call
* spi_finalize_current_message() so the subsystem can issue the next
* transfer
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/wireless')
0 files changed, 0 insertions, 0 deletions