summaryrefslogtreecommitdiff
path: root/fs/cifs/cifssmb.c
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2009-05-26 20:28:11 (GMT)
committerSteve French <sfrench@us.ibm.com>2009-05-26 21:10:55 (GMT)
commitf55ed1a83d099f275c9560ad7d4c4700d1e54bdd (patch)
tree863038ab400c725cd7be24ff8782a313ed6a20a0 /fs/cifs/cifssmb.c
parent46a7574caf5bc533c24b315800ed323c187614f5 (diff)
downloadlinux-fsl-qoriq-f55ed1a83d099f275c9560ad7d4c4700d1e54bdd.tar.xz
cifs: tighten up default file_mode/dir_mode
The current default file mode is 02767 and dir mode is 0777. This is extremely "loose". Given that CIFS is a single-user protocol, these permissions allow anyone to use the mount -- in effect, giving anyone on the machine access to the credentials used to mount the share. Change this by making the default permissions restrict write access to the default owner of the mount. Give read and execute permissions to everyone else. These are the same permissions that VFAT mounts get by default so there is some precedent here. Note that this patch also removes the mandatory locking flags from the default file_mode. After having looked at how these flags are used by the kernel, I don't think that keeping them as the default offers any real benefit. That flag combination makes it so that the kernel enforces mandatory locking. Since the server is going to do that for us anyway, I don't think we want the client to enforce this by default on applications that just want advisory locks. Anyone that does want this behavior can always enable it by setting the file_mode appropriately. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/cifssmb.c')
0 files changed, 0 insertions, 0 deletions