diff options
author | Sasha Levin <sasha.levin@oracle.com> | 2013-12-07 22:26:27 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-01-15 23:31:34 (GMT) |
commit | a84305bbc625fac01f8700c26d25c99f4d846c56 (patch) | |
tree | e84e020acef101c721954a25b4ebc2d6c2eec0a7 /net/core/sock.c | |
parent | e7556142c6db8a3a748d597a917e84a525c1b15e (diff) | |
download | linux-fsl-qoriq-a84305bbc625fac01f8700c26d25c99f4d846c56.tar.xz |
net: unix: allow set_peek_off to fail
[ Upstream commit 12663bfc97c8b3fdb292428105dd92d563164050 ]
unix_dgram_recvmsg() will hold the readlock of the socket until recv
is complete.
In the same time, we may try to setsockopt(SO_PEEK_OFF) which will hang until
unix_dgram_recvmsg() will complete (which can take a while) without allowing
us to break out of it, triggering a hung task spew.
Instead, allow set_peek_off to fail, this way userspace will not hang.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/core/sock.c')
-rw-r--r-- | net/core/sock.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/sock.c b/net/core/sock.c index 0b39e7a..5cec994 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -888,7 +888,7 @@ set_rcvbuf: case SO_PEEK_OFF: if (sock->ops->set_peek_off) - sock->ops->set_peek_off(sk, val); + ret = sock->ops->set_peek_off(sk, val); else ret = -EOPNOTSUPP; break; |