summaryrefslogtreecommitdiff
path: root/sound/firewire
diff options
context:
space:
mode:
authorDaniel Santos <daniel.santos@pobox.com>2014-01-05 23:39:26 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-02-13 21:50:15 (GMT)
commit24175707cb728921b5ad1cf1095d1600a07dda2e (patch)
tree274fdff7ca7656cc3c196ba3d10fbfeed708c676 /sound/firewire
parentdd00c35310801bcdb164a40e745f7def5cef8188 (diff)
downloadlinux-fsl-qoriq-24175707cb728921b5ad1cf1095d1600a07dda2e.tar.xz
spidev: fix hang when transfer_one_message fails
commit e120cc0dcf2880a4c5c0a6cb27b655600a1cfa1d upstream. This corrects a problem in spi_pump_messages() that leads to an spi message hanging forever when a call to transfer_one_message() fails. This failure occurs in my MCP2210 driver when the cs_change bit is set on the last transfer in a message, an operation which the hardware does not support. Rationale Since the transfer_one_message() returns an int, we must presume that it may fail. If transfer_one_message() should never fail, it should return void. Thus, calls to transfer_one_message() should properly manage a failure. Fixes: ffbbdd21329f3 (spi: create a message queueing infrastructure) Signed-off-by: Daniel Santos <daniel.santos@pobox.com> Signed-off-by: Mark Brown <broonie@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/firewire')
0 files changed, 0 insertions, 0 deletions