diff options
| author | Stephen Warren <swarren@wwwdotorg.org> | 2015-10-03 19:56:48 (GMT) |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2015-10-24 17:50:34 (GMT) |
| commit | 47b71644500f7dff768254570ff62c6e985e4bc3 (patch) | |
| tree | b8e23263e642ae4cdfdafadfd490f1e22d123ca4 | |
| parent | 4a28274227d085d77d46709dc94ccc3d69610f53 (diff) | |
| download | u-boot-fsl-qoriq-47b71644500f7dff768254570ff62c6e985e4bc3.tar.xz | |
fs-test.sh: fix pre-requisite detection
In the following snippet:
if [ ! -x `which $prereq` ]; then
When $prereq does not exist, `which $prereq` evaluates to the empty string,
which results in *no* argument being passed to the -x operator, which then
evaluates to true, which is the equivalent of the prereq having been found. In
order for this to fail as expected, we must pass an empty argument, which then
causes -x to fail. Do this by wrapping the `` in quotes so there's always an
argument to -x, even if the value of the argument is zero-length.
Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
| -rwxr-xr-x | test/fs/fs-test.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh index 6f0a345..fc41c04 100755 --- a/test/fs/fs-test.sh +++ b/test/fs/fs-test.sh @@ -58,7 +58,7 @@ GB2p5="${MOUNT_DIR}/${BIG_FILE}" # Check if the prereq binaries exist, or exit function check_prereq() { for prereq in $PREREQ_BINS; do - if [ ! -x `which $prereq` ]; then + if [ ! -x "`which $prereq`" ]; then echo "Missing $prereq binary. Exiting!" exit fi |