diff options
author | Stefan Roese <sr@denx.de> | 2008-06-02 15:37:28 (GMT) |
---|---|---|
committer | Stefan Roese <sr@denx.de> | 2008-06-03 18:22:19 (GMT) |
commit | bbeff30cbd1c5d551eb0ad1c2239ec01844c0b0a (patch) | |
tree | 48f48eadf87f5bc67d2673b7f1ba58a77e882dc2 /board/eric | |
parent | 192f90e272b3989ee7b4a666d1fdab831f20f8d2 (diff) | |
download | u-boot-fsl-qoriq-bbeff30cbd1c5d551eb0ad1c2239ec01844c0b0a.tar.xz |
ppc4xx: Remove superfluous dram_init() call or replace it by initdram()
Historically the 405 U-Boot port had a dram_init() call in early init
stage. This function was still called from start.S and most of the time
coded in assembler. This is not needed anymore (since a long time) and
boards should implement the common initdram() function in C instead.
This patch now removed the dram_init() call from start.S and removes the
empty implementations that are scattered through most of the 405 board
ports. Some older board ports really implement this dram_init() though.
These are:
csb272
csb472
ERIC
EXBITGEN
W7OLMC
W7OLMG
I changed those boards to call this assembler dram_init() function now
from their board specific initdram() instead. This *should* work, but please
test again on those platforms. And it is perhaps a good idea that those
boards use some common 405 SDRAM initialization code from cpu/ppc4xx at
some time. So further patches welcome here.
Signed-off-by: Stefan Roese <sr@denx.de>
Diffstat (limited to 'board/eric')
-rw-r--r-- | board/eric/eric.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/board/eric/eric.c b/board/eric/eric.c index 5413ae1..14ba9b0 100644 --- a/board/eric/eric.c +++ b/board/eric/eric.c @@ -31,6 +31,8 @@ #define PPC405GP_GPIO0_ODR 0xef600718 /* GPIO Open Drain */ #define PPC405GP_GPIO0_IR 0xef60071c /* GPIO Input */ +void sdram_init(void); + int board_early_init_f (void) { @@ -127,6 +129,12 @@ long int initdram (int board_type) int TotalSize; #endif + /* + * ToDo: Move the asm init routine sdram_init() to this C file, + * or even better use some common ppc4xx code available + * in cpu/ppc4xx + */ + sdram_init(); #ifdef CONFIG_ERIC /* |