diff options
author | Neal Cardwell <ncardwell@google.com> | 2012-03-27 19:09:37 (GMT) |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2012-04-06 11:24:17 (GMT) |
commit | 6f103929f8979d2638e58d7f7fda0beefcb8ee7e (patch) | |
tree | e1ef3fc388c177e8e8ca4b6daa797fe7f9306d84 /lib/bitrev.c | |
parent | 3872c48b14259d8c0a00c9fff06a4a4123f7f4eb (diff) | |
download | linux-fsl-qoriq-6f103929f8979d2638e58d7f7fda0beefcb8ee7e.tar.xz |
nohz: Fix stale jiffies update in tick_nohz_restart()
Fix tick_nohz_restart() to not use a stale ktime_t "now" value when
calling tick_do_update_jiffies64(now).
If we reach this point in the loop it means that we crossed a tick
boundary since we grabbed the "now" timestamp, so at this point "now"
refers to a time in the old jiffy, so using the old value for "now" is
incorrect, and is likely to give us a stale jiffies value.
In particular, the first time through the loop the
tick_do_update_jiffies64(now) call is always a no-op, since the
caller, tick_nohz_restart_sched_tick(), will have already called
tick_do_update_jiffies64(now) with that "now" value.
Note that tick_nohz_stop_sched_tick() already uses the correct
approach: when we notice we cross a jiffy boundary, grab a new
timestamp with ktime_get(), and *then* update jiffies.
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Cc: Ben Segall <bsegall@google.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1332875377-23014-1-git-send-email-ncardwell@google.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'lib/bitrev.c')
0 files changed, 0 insertions, 0 deletions