diff options
author | Julia Lawall <julia@diku.dk> | 2008-07-21 09:29:34 (GMT) |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2008-07-29 20:55:05 (GMT) |
commit | 4104863fb4a724723d1d5f3cba9d3c5084087e45 (patch) | |
tree | 33057dc360a472cb464a699e15fc94b9be329821 | |
parent | 80c42affad970c8ebc5ebec4681aef8dadf21c32 (diff) | |
download | linux-fsl-qoriq-4104863fb4a724723d1d5f3cba9d3c5084087e45.tar.xz |
b43legacy: Release mutex in error handling code
The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.
The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression l;
@@
mutex_lock(l);
... when != mutex_unlock(l)
when any
when strict
(
if (...) { ... when != mutex_unlock(l)
+ mutex_unlock(l);
return ...;
}
|
mutex_unlock(l);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Cc: stable <stable@kernel.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/b43legacy/main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c index cb5ad4f..2541c81 100644 --- a/drivers/net/wireless/b43legacy/main.c +++ b/drivers/net/wireless/b43legacy/main.c @@ -3845,10 +3845,10 @@ static int b43legacy_resume(struct ssb_device *dev) goto out; } } - mutex_unlock(&wl->mutex); b43legacydbg(wl, "Device resumed.\n"); out: + mutex_unlock(&wl->mutex); return err; } |