diff options
| author | Jerome Glisse <jglisse@redhat.com> | 2010-01-13 11:32:36 (GMT) |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2010-01-14 01:53:21 (GMT) |
| commit | 6398d42454ce1671b3422c34fd0f600c9c76c8b1 (patch) | |
| tree | d52d909cc653b1fb9a6553ca973900d1bea2aabf | |
| parent | 7a15cbd40108a670baae71cbd3cec62b65891fa6 (diff) | |
| download | linux-fsl-qoriq-6398d42454ce1671b3422c34fd0f600c9c76c8b1.tar.xz | |
drm/radeon/kms: Do not unpin buffer in fb destruction
It's not necessary to unpin buffer in fb destruction. pin/unpin
need to be balanced and we don't pin in fb creation. We pin when
an fb is associated to a crtc and unpin when the fb is disassociated
from the crtc.
Note:
Maybe we should take reference on fb in set_base callback so fb
doesn't disappear until it's unbind from ctrc.
Signed-off-by: Jerome Glisse <jglisse@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/radeon/radeon_display.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 47ceae9..49f3c69 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -668,7 +668,6 @@ static void radeon_user_framebuffer_destroy(struct drm_framebuffer *fb) radeonfb_remove(dev, fb); if (radeon_fb->obj) { - radeon_gem_object_unpin(radeon_fb->obj); mutex_lock(&dev->struct_mutex); drm_gem_object_unreference(radeon_fb->obj); mutex_unlock(&dev->struct_mutex); |