diff options
| author | Jan H. Schönherr <schnhrr@cs.tu-berlin.de> | 2011-07-19 19:10:26 (GMT) |
|---|---|---|
| committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2011-07-20 21:10:20 (GMT) |
| commit | 7f70893173b056df691b2ee7546bb44fd9abae6a (patch) | |
| tree | 5ac9a61694116b0743b3f407ee935bb07e9271e2 | |
| parent | cefcb602012482003ca2ccc44fcba628d006e4bd (diff) | |
| download | linux-fsl-qoriq-7f70893173b056df691b2ee7546bb44fd9abae6a.tar.xz | |
rcu: Fix wrong check in list_splice_init_rcu()
If the list to be spliced is empty, then list_splice_init_rcu() has
nothing to do. Unfortunately, list_splice_init_rcu() does not check
the list to be spliced; it instead checks the list to be spliced into.
This results in memory leaks given current usage. This commit
therefore fixes the empty-list check.
Signed-off-by: Jan H. Schönherr <schnhrr@cs.tu-berlin.de>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
| -rw-r--r-- | include/linux/rculist.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/rculist.h b/include/linux/rculist.h index e3beb31..d079290 100644 --- a/include/linux/rculist.h +++ b/include/linux/rculist.h @@ -183,7 +183,7 @@ static inline void list_splice_init_rcu(struct list_head *list, struct list_head *last = list->prev; struct list_head *at = head->next; - if (list_empty(head)) + if (list_empty(list)) return; /* "first" and "last" tracking list, so initialize it. */ |