summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-01-24 21:59:31 (GMT)
committerDavid S. Miller <davem@davemloft.net>2012-01-25 21:58:26 (GMT)
commita44acd551467d78a26bfa76ea348225575830efc (patch)
tree66ab6bcbbe391ac502652ffeb2682f283be0c849
parent8bca5d1ebb8bf18187256845ba3aaff5fbc01934 (diff)
downloadlinux-fsl-qoriq-a44acd551467d78a26bfa76ea348225575830efc.tar.xz
bnx2x: unlock before returning an error
We introduced a new return here but forgot to drop the lock. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Dmitry Kravkov <dmitry@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index cb6339c..69465c3 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -1836,6 +1836,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp,
rc = exeq->remove(bp, exeq->owner, exeq_pos);
if (rc) {
BNX2X_ERR("Failed to remove command\n");
+ spin_unlock_bh(&exeq->lock);
return rc;
}
list_del(&exeq_pos->link);