diff options
| author | Eldad Zack <eldad@fogrefinery.com> | 2012-07-06 19:31:56 (GMT) |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2012-07-11 20:07:59 (GMT) |
| commit | d9c2ede63c74048dfddbb129c59ac01176b0ab71 (patch) | |
| tree | 355767a58545b8e1d0626a1d08fe83f26c7228e7 | |
| parent | 7f2e7dc0fdd9f124da43d1bd12adcebf92bedf16 (diff) | |
| download | linux-fsl-qoriq-d9c2ede63c74048dfddbb129c59ac01176b0ab71.tar.xz | |
sunrpc/cache.h: fix coding style
Neaten code style in get_int().
Also use sizeof() instead of hard coded number as suggested by
Joe Perches <joe@perches.com>.
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
| -rw-r--r-- | include/linux/sunrpc/cache.h | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/include/linux/sunrpc/cache.h b/include/linux/sunrpc/cache.h index f5fd616..6def1f6 100644 --- a/include/linux/sunrpc/cache.h +++ b/include/linux/sunrpc/cache.h @@ -219,11 +219,17 @@ static inline int get_int(char **bpp, int *anint) char buf[50]; char *ep; int rv; - int len = qword_get(bpp, buf, 50); - if (len < 0) return -EINVAL; - if (len ==0) return -ENOENT; + int len = qword_get(bpp, buf, sizeof(buf)); + + if (len < 0) + return -EINVAL; + if (len == 0) + return -ENOENT; + rv = simple_strtol(buf, &ep, 0); - if (*ep) return -EINVAL; + if (*ep) + return -EINVAL; + *anint = rv; return 0; } |