diff options
author | Lars-Peter Clausen <lars@metafoo.de> | 2012-07-04 16:09:00 (GMT) |
---|---|---|
committer | Jonathan Cameron <jic23@kernel.org> | 2012-07-08 19:02:29 (GMT) |
commit | da0f01e1ed88b4ac650d884e4e2ee11c9cd4d83b (patch) | |
tree | adab034fa80a31fc0d8a3337f560080f2dc14dd7 | |
parent | 46b2495cc79484769e6c9364bf8f2e8b8e9de1aa (diff) | |
download | linux-fsl-qoriq-da0f01e1ed88b4ac650d884e4e2ee11c9cd4d83b.tar.xz |
staging:iio:max1363: Do not return error code in interrupt handler
The interrupt handler should only ever return one of the three irqreturn_t
constants and not an error code. Also make sure to always call
iio_trigger_notify_done before leaving the trigger handler.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
-rw-r--r-- | drivers/staging/iio/adc/max1363_ring.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/iio/adc/max1363_ring.c b/drivers/staging/iio/adc/max1363_ring.c index b302013..bf6b0c2 100644 --- a/drivers/staging/iio/adc/max1363_ring.c +++ b/drivers/staging/iio/adc/max1363_ring.c @@ -64,11 +64,11 @@ static irqreturn_t max1363_trigger_handler(int irq, void *p) * no harm. */ if (numvals == 0) - return IRQ_HANDLED; + goto done; rxbuf = kmalloc(d_size, GFP_KERNEL); if (rxbuf == NULL) - return -ENOMEM; + goto done; if (st->chip_info->bits != 8) b_sent = i2c_master_recv(st->client, rxbuf, numvals*2); else |