diff options
| author | Rupesh Gujare <rupesh.gujare@atmel.com> | 2013-08-23 15:11:01 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-08-23 17:12:32 (GMT) |
| commit | dfc065f19fe0ce4ef7a52011801c5c19131e6529 (patch) | |
| tree | d5bd9275b39e989ad4e5b4df66159c0925b3e114 | |
| parent | 9efed32c223a0dabebeeeca7c1b3cdafb97fbde4 (diff) | |
| download | linux-fsl-qoriq-dfc065f19fe0ce4ef7a52011801c5c19131e6529.tar.xz | |
staging: ozwpan: Fix wrong error check.
schedule_work() returns true if succeeded & false on failure,
error check was doing exactly reverse.
Also removes extra variable.
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/ozwpan/ozpd.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c index 5d24af3..d39a3df 100644 --- a/drivers/staging/ozwpan/ozpd.c +++ b/drivers/staging/ozwpan/ozpd.c @@ -261,17 +261,13 @@ void oz_pd_free(struct work_struct *work) */ void oz_pd_destroy(struct oz_pd *pd) { - int ret; - if (hrtimer_active(&pd->timeout)) hrtimer_cancel(&pd->timeout); if (hrtimer_active(&pd->heartbeat)) hrtimer_cancel(&pd->heartbeat); INIT_WORK(&pd->workitem, oz_pd_free); - ret = schedule_work(&pd->workitem); - - if (ret) + if (!schedule_work(&pd->workitem)) oz_pd_dbg(pd, ON, "failed to schedule workitem\n"); } |