summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@infradead.org>2008-04-13 17:55:38 (GMT)
committerMauro Carvalho Chehab <mchehab@infradead.org>2008-04-24 17:08:10 (GMT)
commite74153d44a57d9445fb1dfad7c3accbec6d4a873 (patch)
treef8fe30f6751860b7e28a0011f639128803442e9a
parentf245e549f0d1fb43fd6d7759d31cd763e6d914b6 (diff)
downloadlinux-fsl-qoriq-e74153d44a57d9445fb1dfad7c3accbec6d4a873.tar.xz
V4L/DVB (7547): em28xx: Fix a broken lock
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
-rw-r--r--drivers/media/video/em28xx/em28xx-video.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index c559352..033ecb4 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -790,15 +790,12 @@ static int res_get(struct em28xx_fh *fh)
if (fh->stream_on)
return rc;
- mutex_lock(&dev->lock);
-
if (dev->stream_on)
- rc = -EINVAL;
- else {
- dev->stream_on = 1;
- fh->stream_on = 1;
- }
+ return -EINVAL;
+ mutex_lock(&dev->lock);
+ dev->stream_on = 1;
+ fh->stream_on = 1;
mutex_unlock(&dev->lock);
return rc;
}