diff options
author | Daniel Borkmann <dborkman@redhat.com> | 2013-02-12 13:30:16 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-02-13 18:42:34 (GMT) |
commit | e9c0dfbaa28b7c9f5d3482633770cdeec53e3f7b (patch) | |
tree | 6a94c3f432e282dad04b2c8f83c33450c098867a /Documentation/powerpc/ptrace.txt | |
parent | 816cd5b83e4d8f3c8106966e64a025408caee3f6 (diff) | |
download | linux-fsl-qoriq-e9c0dfbaa28b7c9f5d3482633770cdeec53e3f7b.tar.xz |
net: sctp: sctp_v6_get_dst: fix boolean test in dst cache
We walk through the bind address list and try to get the best source
address for a given destination. However, currently, we take the
'continue' path of the loop when an entry is invalid (!laddr->valid)
*and* the entry state does not equal SCTP_ADDR_SRC (laddr->state !=
SCTP_ADDR_SRC).
Thus, still, invalid entries with SCTP_ADDR_SRC might not 'continue'
as well as valid entries with SCTP_ADDR_{NEW, SRC, DEL}, with a possible
false baddr and matchlen as a result, causing in worst case dst route
to be false or possibly NULL.
This test should actually be a '||' instead of '&&'. But lets fix it
and make this a bit easier to read by having the condition the same way
as similarly done in sctp_v4_get_dst.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation/powerpc/ptrace.txt')
0 files changed, 0 insertions, 0 deletions