diff options
author | Steven Rostedt <rostedt@goodmis.org> | 2013-01-25 17:13:15 (GMT) |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2013-01-31 14:14:59 (GMT) |
commit | 196897a2979498d19edbdf5b4af02261afbc1a96 (patch) | |
tree | e3db3cbfba4654cf63b4840061392cbe87e088eb /arch/cris/kernel | |
parent | 26f5ae865d7b324e46fff91acf43c485939bf6ea (diff) | |
download | linux-fsl-qoriq-196897a2979498d19edbdf5b4af02261afbc1a96.tar.xz |
mips: Move __virt_addr_valid() to a place for MIPS 64
Commit d3ce88431892 "MIPS: Fix modpost error in modules attepting to use
virt_addr_valid()" moved __virt_addr_valid() from a macro in a header
file to a function in ioremap.c. But ioremap.c is only compiled for MIPS
32, and not for MIPS 64.
When compiling for my yeeloong2, which supposedly supports hibernation,
which compiles kernel/power/snapshot.c which calls virt_addr_valid(), I
got this error:
LD init/built-in.o
kernel/built-in.o: In function `memory_bm_free':
snapshot.c:(.text+0x4c9c4): undefined reference to `__virt_addr_valid'
snapshot.c:(.text+0x4ca58): undefined reference to `__virt_addr_valid'
kernel/built-in.o: In function `snapshot_write_next':
(.text+0x4e44c): undefined reference to `__virt_addr_valid'
kernel/built-in.o: In function `snapshot_write_next':
(.text+0x4e890): undefined reference to `__virt_addr_valid'
make[1]: *** [vmlinux] Error 1
make: *** [sub-make] Error 2
I suspect that __virt_addr_valid() is fine for mips 64. I moved it to
mmap.c such that it gets compiled for mips 64 and 32.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/4842/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/cris/kernel')
0 files changed, 0 insertions, 0 deletions