diff options
| author | H. Peter Anvin <hpa@zytor.com> | 2007-07-14 23:47:13 (GMT) |
|---|---|---|
| committer | H. Peter Anvin <hpa@zytor.com> | 2007-07-18 18:36:17 (GMT) |
| commit | 5593eaa854d0b23c3b270933a93b9b82946df729 (patch) | |
| tree | f1efc4a66fcc25749db43eaa77e3075c65b2a1ab /arch/i386/boot/voyager.c | |
| parent | 9aa3909c0ea33da41755e15182fa4f88ae036d83 (diff) | |
| download | linux-fsl-qoriq-5593eaa854d0b23c3b270933a93b9b82946df729.tar.xz | |
[x86 setup] Fix assembly constraints
Fix incorrect assembly constraints. In particular, fix memory
constraints used inside push..pop, which can cause invalid operation
since gcc may generate %esp-relative references.
Additionally:
outl() should have "dN" not "dn".
query_mca() shouldn't listen 16/32-bit registers in an 8-bit only
context.
has_eflag(): the "mask" is only used well after both the stack pointer
and the output registers have been touched; this requires the output
registers to be earlyclobbers (=&) and the input to exclude memory (so
"ri", not "g").
Thanks to Etienne Lorrain and Chuck Ebbert for prompting this review.
Cc: Etienne Lorrain <etienne_lorrain@yahoo.fr>
Cc: Chuck Ebbert <cebbert@redhat.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/i386/boot/voyager.c')
| -rw-r--r-- | arch/i386/boot/voyager.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/i386/boot/voyager.c b/arch/i386/boot/voyager.c index 9221614..61c8fe0 100644 --- a/arch/i386/boot/voyager.c +++ b/arch/i386/boot/voyager.c @@ -32,7 +32,7 @@ int query_voyager(void) "setc %0 ; " "movw %%es, %1 ; " "popw %%es" - : "=qm" (err), "=rm" (es), "=D" (di) + : "=q" (err), "=r" (es), "=D" (di) : "a" (0xffc0)); if (err) |